Issue with foreign keys defined in "app.ModelName" format in abstract base classes #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzkji
changed the title
benzkji
changed the title
|
Probably, yes. We expect there a model, not a string. |
|
But in this edge case, it is a string. Nothing special, or do you see something special in my example code? Defining foreign key field's models as strings is supported and sometimes necessary, in Django, so shouldn't it be with modeltranslation? |
|
That looks like error, or maybe we're accessing it at the wrong time (during init). If you look at any other foreign key, |
|
Agreed. Hard to tackle down. It's really only when in an abstract base class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the field.model is not yet a class, but still a string, in this particular case.
Tried a fix (modeltranslation/fields.py), but issue seems deeper, I guess it should really just not be a string?
This PR just shows the problem.