Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#727 wip, added tests #729

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benzkji
Copy link

@benzkji benzkji commented Apr 20, 2024

I've added tests, but don't know how I could add migrations for the new models needed for testing.

@benzkji
Copy link
Author

benzkji commented Apr 20, 2024

  • Added migration with poetry run django-admin makemigrations tests --settings=modeltranslation.tests.settings.
  • Had to add Pillow to dev dependencies, was not able to run makemigrations otherwise.

A few tests (5) fail now, because the test object cannot be deleted anymore ;)

@benzkji
Copy link
Author

benzkji commented Apr 21, 2024

I can't get it to work properly. See my latest commit, that's how it's supposed to be setup?

@benzkji benzkji changed the title #727 wip, added tests, without migrations #727 wip, added tests Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants