[1.x] Support environment variable DUSK_START_MAXIMIZED for Chromedriver
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI environments such as GitHub Actions can set DUSK_START_MAXIMIZED=true to open the web browser without needing to set an exact widthxheight.
derekmd
force-pushed
the
feat/start-maximized-env-var
branch
from
eafa53d to
8cea2fa
Compare
derekmd
changed the title
DUSK_START_MAXIMIZEDDUSK_START_MAXIMIZED for Chromedriver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasStartMaximizedEnabledmethod. laravel/dusk#978CI environments such as GitHub Actions can set
DUSK_START_MAXIMIZED=trueto open the web browser without needing to set an exact width x height.--start-maximizedis a capability option only supported by Chromedriver.$browser->maximize()within the test after the Mozilla Firefox browser window is created.Apps must call
php artisan dusk:install-firefox --with-chrometo copy the updated file stub with the new feature.