Merge pull request #26 from derekmd/feat/start-maximized-env-var

[1.x] Support environment variable `DUSK_START_MAXIMIZED` for Chromedriver
derekmd · Feb 10, 2023 · 73681b2 · 73681b2
2 parents ae0747e + 8cea2fa
commit 73681b2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/Concerns/TogglesHeadlessMode.php b/src/Concerns/TogglesHeadlessMode.php
@@ -30,4 +30,15 @@ protected function hasHeadlessDisabled()
         return isset($_SERVER['DUSK_HEADLESS_DISABLED']) ||
                isset($_ENV['DUSK_HEADLESS_DISABLED']);
     }
+
+    /**
+     * Determine if the browser window should start maximized.
+     *
+     * @return bool
+     */
+    protected function shouldStartMaximized()
+    {
+        return isset($_SERVER['DUSK_START_MAXIMIZED']) ||
+               isset($_ENV['DUSK_START_MAXIMIZED']);
+    }
 }
diff --git a/stubs/DuskTestCase.stub b/stubs/DuskTestCase.stub
@@ -57,7 +57,7 @@ abstract class DuskTestCase extends BaseTestCase
         $options = (new ChromeOptions)->addArguments($this->filterHeadlessArguments([
             '--disable-gpu',
             '--headless',
-            '--window-size=1920,1080',
+            $this->shouldStartMaximized() ? '--start-maximized' : '--window-size=1920,1080',
         ]));
 
         return RemoteWebDriver::create(

diff --git a/stubs/FirefoxDuskTestCase.stub b/stubs/FirefoxDuskTestCase.stub
@@ -21,11 +21,9 @@ abstract class DuskTestCase extends BaseTestCase
      */
     public static function prepare()
     {
-        if (static::runningFirefoxInSail()) {
-            return;
+        if (! static::runningFirefoxInSail()) {
+            static::startFirefoxDriver();
         }
-
-        static::startFirefoxDriver();
     }
 
     /**