Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): Make TwoColumnPanel wrap to prevent content from getting cut out #952

Merged
merged 4 commits into from
Mar 15, 2023
Merged

fix(react): Make TwoColumnPanel wrap to prevent content from getting cut out #952

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36d7fcc
fix(react): Make TwoColumnPanel wrap to prevent content from getting …
dequejosie Mar 15, 2023
58fa7f6
change
dequejosie Mar 15, 2023
900612c
padding
dequejosie Mar 15, 2023
d8b70d2
comment
dequejosie Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/styles/two-column-panel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@
}

.TwoColumnPanel__Header {
padding: 0 var(--space-small);
/* The -2px is to account for the borders that are outside of the element and will make it line up with the left panel when there's only one line of text */
padding: calc(var(--space-small) - 2px);
border-bottom: 1px solid var(--two-column-panel-border-color);
height: var(--two-column-panel-header-height);
line-height: var(--two-column-panel-header-height);
min-height: var(--two-column-panel-header-height);
font-weight: 500;
color: var(--two-column-panel-header-text-color);
flex: 1;
display: flex;
align-items: center;
}

.TwoColumnPanel__Left {
Expand Down Expand Up @@ -176,12 +178,16 @@
margin-bottom: 0;
}

.TwoColumnPanel__ButtonToggle {
display: flex;
}
dequejosie marked this conversation as resolved.
Show resolved Hide resolved

.TwoColumnPanel__ButtonToggle button,
.TwoColumnPanel__Close button {
background-color: transparent;
border: none;
border-bottom: 1px solid var(--two-column-panel-border-color);
height: var(--two-column-panel-header-height);
min-height: var(--two-column-panel-header-height);
scurker marked this conversation as resolved.
Show resolved Hide resolved
width: var(--two-column-panel-header-height);
}

Expand Down