-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): Make TwoColumnPanel wrap to prevent content from getting cut out #952
Conversation
Preview branch generated at https://two-column-panel-header.d1gko6en628vir.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @dequejosie!
Just one small tweak is needed to make the padding consistent when it wraps. Since the line-height was removed, we need to set the padding for .TwoColumnPanel__Header
so it doesn't look squished when content wraps:
padding: calc(var(--space-small) - 2px);
The -2px
is to account for the borders that are outside of the element and will make it line up with the left panel when there's only one line of text.
Preview branch generated at https://two-column-panel-header.d1gko6en628vir.amplifyapp.com |
closes #786