fix(react): Make TwoColumnPanel wrap to prevent content from getting cut out #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dequejosie
commented
Mar 15, 2023
|
Preview branch generated at https://two-column-panel-header.d1gko6en628vir.amplifyapp.com |
scurker
previously requested changes
Mar 15, 2023
There was a problem hiding this comment.
Great work @dequejosie!
Just one small tweak is needed to make the padding consistent when it wraps. Since the line-height was removed, we need to set the padding for .TwoColumnPanel__Header so it doesn't look squished when content wraps:
padding: calc(var(--space-small) - 2px);The -2px is to account for the borders that are outside of the element and will make it line up with the left panel when there's only one line of text.
dequejosie
commented
Mar 15, 2023
|
|
scurker
approved these changes
Mar 15, 2023
|
Preview branch generated at https://two-column-panel-header.d1gko6en628vir.amplifyapp.com |
This was referenced Mar 21, 2023
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #786