Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(type-checking): Cannot use only callback in run() without ts error #707

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

plumpNation
Copy link
Contributor

Addresses #706

@WilcoFiers
Copy link
Contributor

Cool! Can you also add the scenario where there's no callback? If you don't use a callback, aXe will return a thenable.

@plumpNation
Copy link
Contributor Author

plumpNation commented Feb 4, 2018

Ok no worries. I have removed the optional params and locked it down with explicit overloads instead.

I have also added some types to make the overloads more readable.

@WilcoFiers
Copy link
Contributor

Awesome. Thanks for the contribution @plumpNation Just a heads up, it'll be a few weeks before we can release this, since we're trying to put everything in its place to release aXe 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants