Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run() function optional parameters create typescript error #706

Closed
plumpNation opened this issue Feb 1, 2018 · 0 comments
Closed

run() function optional parameters create typescript error #706

plumpNation opened this issue Feb 1, 2018 · 0 comments

Comments

@plumpNation
Copy link
Contributor

the axe.d.ts file has three optional parameters, however, the run function handles internally providing the callback on it's own.

axe.run(callback);

The recommended approaches I have found say use undefined for the optionals, however this causes issues with normalizeRunParams() that determines which parameter you are passing in.

I suggest adding overloads to the axe.d.ts file to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants