fix(aria-hidden-focus): Update rule help & description #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `help` value does not include the scenario in which `aria-hidden="true"` is on a focusable element. I updated it to include that scenario. Here's the PR, per Wilco's suggestion. Slack thread: https://deque.slack.com/archives/C0LA5E545/p1646762357136919
|
|
WilcoFiers
reviewed
Mar 25, 2022
WilcoFiers
changed the title
help value to include focusable elements
|
Reviewed for security |
|
Ps. this pr closes issue #3252 |
WilcoFiers
changed the title
|
@straker that's good to know! |
straker
pushed a commit
that referenced
this pull request
May 12, 2022
* Update `help` value to include focusable elements The current `help` value does not include the scenario in which `aria-hidden="true"` is on a focusable element. I updated it to include that scenario. Here's the PR, per Wilco's suggestion. Slack thread: https://deque.slack.com/archives/C0LA5E545/p1646762357136919 * Update lib/rules/aria-hidden-focus.json Co-authored-by: Wilco Fiers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
helpvalue does not include the scenario in whicharia-hidden="true"is on a focusable element. I updated it to include that scenario. Here's the PR, per @WilcoFiers suggestion. Slack thread: https://deque.slack.com/archives/C0LA5E545/p1646762357136919