-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for aria-hidden-focus
for single element is misleading and not fully correct
#3252
Comments
Thanks for the issue. We'll try to update the message to make it more clear. |
Hey @straker how is the process going on improving the messaging. We actually just tweeted about this issue https://twitter.com/TechThomas/status/1488413276400922624 |
We weren't able to get this into the 4.4.0 release which just went out, but we can try to get it added to 4.4.1. |
@straker when will 4.4.1 be expected? |
Sorry, 4.4.1 was released not too long ago but did not include this fix (it was a quick release to fix a bug in 4.4.0). I'm not sure when we plan on releasing the next release, so I'm unable able to say when this will be addressed. |
Product: axe-core
Expectation:
<input aria-hidden="true">
failing test foraria-hidden-focus
and having clear help message explaining why this element is failing.Actual: axe core 4.3.5 reports
aria-hidden-focus
violation with description about its elements (which don't exist).Motivation: misleading help text made some tech support to think there is false positive with axe rule, because it's mentioning
do not contain elements
, and there are just one single DOM element, with no other elements that it contains that may be failing this test.I know it sounds a little bit nerdy, but such help text have to be clear, as it's getting even worse when it's got to Lighthouse: https://github.com/GoogleChrome/lighthouse/blob/8a29854072202807ba54276beb9cdd9f244007b5/lighthouse-core/audits/accessibility/aria-hidden-focus.js#L18
__
minimal repro example:
axe help text: "ARIA hidden element must not contain focusable elements"
Lighthouse title: "
[aria-hidden="true"]
elements do not contain focusable descendents"The text was updated successfully, but these errors were encountered: