Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-required-attr): only require aria-controls if aria-expanded=true #3089

Merged
merged 3 commits into from
Jul 21, 2021
Merged

fix(aria-required-attr): only require aria-controls if aria-expanded=true #3089

merged 3 commits into from
Jul 21, 2021

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 21, 2021 •
edited
Loading

Closes issue #3090

The diff's a bit off as it thinks I changed contents of the first test instead of adding one above what was there.

@straker straker requested a review from a team as a code owner July 21, 2021 14:30
@straker straker merged commit 63b6c7b into develop Jul 21, 2021
@straker straker deleted the fix-combobox-1.2 branch July 21, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers