Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-required fails on combobox without aria-expanded #3090

Closed
straker opened this issue Jul 21, 2021 · 6 comments
Closed

aria-required fails on combobox without aria-expanded #3090

straker opened this issue Jul 21, 2021 · 6 comments
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule

Comments

@straker
Copy link
Contributor

straker commented Jul 21, 2021

This should not fail as pointed out in #2505 (comment)

<div role="combobox"></div>
@straker straker added fix Bug fixes rules Issue or false result from an axe-core rule labels Jul 21, 2021
@straker straker added the pr A pr has been created for the issue label Jul 21, 2021
@padmavemulapati
Copy link

padmavemulapati commented Aug 5, 2021

Validated with the latest code ,
its giving failure for the below cases:
<div role="combobox"></div>
and
<div id="target" role="combobox" aria-expanded="true">expanded</div>
image

and as per the issue, if we are not passing any attributes for role=combobox means it is in collapsed state only ,
so that the snippet <div role="combobox"></div> meaning is expanded=false , so that it should not fail
but its showing as failure
@straker , can you please confirm, is the fix applicable only when aria-attributes state is mentioned?

@straker
Copy link
Contributor Author

straker commented Aug 5, 2021

@padmavemulapati no attributes does not equate to expanded=false and aria-expanded is a required attribute which does not have an implicit value defined (so no default) https://www.w3.org/TR/wai-aria-1.2/#combobox

@padmavemulapati
Copy link

@straker , Thank you for the clarification.

@straker
Copy link
Contributor Author

straker commented Sep 28, 2021

No docs

@straker straker closed this as completed Sep 28, 2021
@mshubat
Copy link

mshubat commented Nov 18, 2021

angular/components#23570

This has been mentioned by the Angular team as being a false positive, as the aria-controls attribute is added once the dropdown for the select with role "combobox" is added to the dom.

It seems as though this is still generating false positives. Any plans to address this @straker?

Thank you.

@straker
Copy link
Contributor Author

straker commented Jan 3, 2022

@mshubat The next axe-core release slated for the end of this month should include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants