chore: split test:unit into different parts #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
requested changes
Dec 16, 2020
WilcoFiers
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor quality of life change that helps make running
test:unita little bit nicer. Right now it runs all tests in a single run, but won't fail early if something incommonsfails. This changes it so each directory is run individually so it will exit early if something fails.Not only that, but trying to debug the tests was a bit rough as running all the tests in the browser was slow, especially in IE11 where #2682 was failing but I couldn't reproduce it locally when running that specific test, but could not get all the tests to run properly in the browser. Splitting the tests out should help with debugging.
Lastly, the
test:debugscript just makes it easier to run karma in debug rather than remembering the commands. You can still pass-- testDirsto it so you can debug individual test dirs as well.