fix(color-contrast): account for text client rects that start outside the parent container #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the parent container
Co-authored-by: Wilco Fiers <[email protected]>
WilcoFiers
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element that was causing the problem had 12 client rects, all of them text rects that started on their own lines (so 12 lines of text). Some of those rects started outside the bounds of the element, so we tried to access part of a grid that didn't exist.
Fixed it so if any text rect wasn't fully contained within the parents bounding box, we just use the parents bounding box. Also moved the textElementStack tests to their own file as they were becoming so large.
Closes issue: #2681