tests: test the examples using local version of axe #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that all our examples use an axe-core version from npm and not the local axe.js file. This meant that us testing the examples for every pr and release does not verify the current code works in the examples, only that the last released version of axe-core works.
Since the examples are there as examples, they should act as standalone examples and install axe-core from npm as a normal user would. However, we can still test the local copy of axe for our tests by overriding the npm version with the local version just in the test run.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)