Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(globals): deduce required window and document globals from context #2308

Merged
merged 3 commits into from
Jun 22, 2020
Merged

feat(globals): deduce required window and document globals from context #2308

merged 3 commits into from
Jun 22, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 18, 2020 •
edited by WilcoFiers
Loading

Set the globals if they are missing and we have a valid context.

Closes issue: #1417

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner June 18, 2020 14:30
@straker
Copy link
Contributor Author

straker commented Jun 18, 2020

#2309 has the fix needed to fix the broken test

WilcoFiers
WilcoFiers approved these changes Jun 19, 2020
View reviewed changes
doc/examples/jsdom/test/a11y.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously requested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, no that require needs to be fixed still.

@straker straker merged commit 61bac69 into develop Jun 22, 2020
@jeankaplansky
Copy link
Contributor

Included in internal release notes 7/27/2020

@WilcoFiers WilcoFiers deleted the globals branch January 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straker @jeankaplansky @WilcoFiers