Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-field-multiple-label): incomplete rather than fail for multiple labels #1798

Merged
merged 2 commits into from
Sep 5, 2019
Merged

fix(form-field-multiple-label): incomplete rather than fail for multiple labels #1798

merged 2 commits into from
Sep 5, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Sep 3, 2019 •
edited by WilcoFiers
Loading

Closes issue: #1759

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner September 3, 2019 17:57
@straker straker changed the title fix(form-field-multiple-label): multiple labels will not fail but instead incomplete fix(form-field-multiple-label): incomplete rather than fail for multiple labels Sep 3, 2019
WilcoFiers
WilcoFiers previously requested changes Sep 4, 2019
View reviewed changes
lib/checks/label/multiple-label.js Show resolved Hide resolved
@straker straker merged commit 0bdaa2b into develop Sep 5, 2019
@straker straker deleted the multipleLabel branch September 5, 2019 20:12
@jayaddison jayaddison mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers