-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False Positive: Multiple <label>s marked as errors #1759
Comments
Thanks for all the information. We've decided to mark the rule as "needs review" instead of failures since if all the needed information is in the first label it should be fine. However, we still think it's a wcag failure. @jeankaplansky we also agree that the docs should be updated to use SHOULD instead of MUST for the wcag requirements. |
See rule help ID: form-field-multiple-labels |
Nothing to update after all. |
Hi there! Quick question on the documentation around this issue. In #1759 (comment) it was stated that the docs should change from MUST to SHOULD, currently I'm seeing MUST in the Section 508 in the 3.4 docs, but #1759 (comment) stated there was nothing to update. Am I missing something? Is it the position of axe-core that this is not a failure/could be flaky and is a SHOULD across the board? I ask because we're discussing how to handle this in Lighthouse at the moment now that it will never fail. Our current inclination is to remove it from Lighthouse entirely if it's a "we're not sure" sort of issue, does this line up with your expectations? |
@aardrian The original issue #689 had this helpful table in the comments, https://codepen.io/straker/pen/PvqONy. You can have multiple labels but there are only a few techniques that will work consistently across browser/AT combinations. In looking up that table I noticed this thread, so I wanted to cross-ref them for my future self. |
Sorry @patrickhulce, I must have missed your comment. Reopening the ticket and we'll update the docs to use should (thanks @AutoSponge for commenting so I found this again) |
Relevant docs has been updated - https://dequeuniversity.com/rules/axe/3.5/form-field-multiple-labels |
Expectation: For a field with with multiple
<label>
elements, Axe flags it as a warning (using should language).Actual: When Axe encounters a field with with multiple
<label>
elements, it flags this as an error (using must language).Motivation: Because it generates false positives.
To Reproduce:
Sample Code:
Why Axe Does This:
The Deque page explaining this rule confirms this is considered a failure, suggesting this is not a software bug:
Why I Think Axe Should Not:
<label>
s.<label>
techniques for 1.1.1, 1.3.1, 3.3.2, nor 4.1.2 (H44) forbids multiple<label>
s.<label>
s is valid HTML (tested by pasting the code into the Nu HTML Validator).<label>
s (concatenate by DOM order) suggesting these are valid.Testing tool comparison:
The three tools I see most in use all flag this as an error.
Alternate Outcome:
You tell me I am a wrong wrongerson and tell me to bugger off.
The text was updated successfully, but these errors were encountered: