Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag 'review-items' as 'best-practice' #1344

Merged
merged 3 commits into from
Feb 1, 2019

Conversation

AdnoC
Copy link
Contributor

@AdnoC AdnoC commented Jan 30, 2019

Discussed with @WilcoFiers. This seemed the best way to enable the two rules as just going by experimental isn't enough (since neither rule is part of any standard).

Closes issue: WWD-1929 (once the extension is updated to use this version)

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@AdnoC AdnoC requested a review from a team as a code owner January 30, 2019 19:05
@AdnoC AdnoC merged commit 05f37de into develop Feb 1, 2019
@AdnoC AdnoC deleted the review-items-as-best-practice branch February 1, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants