Skip to content

Commit

Permalink
feat: tag 'review-items' as 'best-practice' (#1344)
Browse files Browse the repository at this point in the history
  • Loading branch information
@AdnoC
AdnoC authored Feb 1, 2019
1 parent e05f222 commit 05f37de
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions doc/rule-descriptions.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
| empty-heading | Ensures headings have discernible text | Minor | cat.name-role-value, best-practice | true |
| focus-order-semantics | Ensures elements in the focus order have an appropriate role | Minor | cat.keyboard, best-practice, experimental | true |
| form-field-multiple-labels | Ensures form field does not have multiple label elements | Moderate | cat.forms, wcag2a, wcag332 | true |
| frame-tested | Ensures <iframe> and <frame> elements contain the axe-core script | Critical | cat.structure, review-item | true |
| frame-tested | Ensures <iframe> and <frame> elements contain the axe-core script | Critical | cat.structure, review-item, best-practice | true |
| frame-title-unique | Ensures <iframe> and <frame> elements contain a unique title attribute | Serious | cat.text-alternatives, best-practice | true |
| frame-title | Ensures <iframe> and <frame> elements contain a non-empty title attribute | Serious | cat.text-alternatives, wcag2a, wcag242, wcag412, section508, section508.22.i | true |
| heading-order | Ensures the order of headings is semantically correct | Moderate | cat.semantics, best-practice | true |
| hidden-content | Informs users about hidden content. | Minor | cat.structure, experimental, review-item | true |
| hidden-content | Informs users about hidden content. | Minor | cat.structure, experimental, review-item, best-practice | true |
| html-has-lang | Ensures every HTML document has a lang attribute | Serious | cat.language, wcag2a, wcag311 | true |
| html-lang-valid | Ensures the lang attribute of the <html> element has a valid value | Serious | cat.language, wcag2a, wcag311 | true |
| html-xml-lang-mismatch | Ensure that HTML elements with both valid lang and xml:lang attributes agree on the base language of the page | Moderate | cat.language, wcag2a, wcag311 | true |
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/frame-tested.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "frame-tested",
"selector": "frame, iframe",
"tags": ["cat.structure", "review-item"],
"tags": ["cat.structure", "review-item", "best-practice"],
"metadata": {
"description": "Ensures <iframe> and <frame> elements contain the axe-core script",
"help": "Frames must be tested with axe-core"
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/hidden-content.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"id": "hidden-content",
"selector": "*",
"excludeHidden": false,
"tags": ["cat.structure", "experimental", "review-item"],
"tags": ["cat.structure", "experimental", "review-item", "best-practice"],
"metadata": {
"description": "Informs users about hidden content.",
"help": "Hidden content on the page cannot be analyzed"
Expand Down

0 comments on commit 05f37de

Please sign in to comment.