fix: prevent TypeErrors in color-contrast checks #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a safeguard to `color.filteredRectStack` which prevents a `TypeError: Cannot read property '0' of undefined` from being thrown. This is not a perfect solution, but a stop-gap instead. It's still unclear why we're getting `undefined` here. More investigation is needed, but this can happen at a later date. Closes #1306 and #1259.
WilcoFiers
approved these changes
Jan 17, 2019
|
You're right. I'll make note of that and will keep one of the issues open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a safeguard to
color.filteredRectStackwhich prevents aTypeError: Cannot read property '0' of undefinedfrom being thrown.This is not a perfect solution, but a stop-gap instead. It's still unclear why we're getting
undefinedhere. More investigation is needed, but this can happen at a later date.Closes #1306 and #1259.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)