Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime issue: TypeError: Cannot read property '0' of undefined #1259

Closed
mattjackson1 opened this issue Nov 26, 2018 · 2 comments · Fixed by #1341
Closed

Runtime issue: TypeError: Cannot read property '0' of undefined #1259

mattjackson1 opened this issue Nov 26, 2018 · 2 comments · Fixed by #1341
Labels
extension Axe Firefox or Chrome extension issues fix Bug fixes

Comments

@mattjackson1
Copy link

<< Please describe how you encountered this issue >>

TypeError: Cannot read property '0' of undefined
    at chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:137989
    at Array.every (<anonymous>)
    at chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:137957
    at Array.forEach (<anonymous>)
    at Object.a.filteredRectStack (chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:137901)
    at Object.a.getBackgroundStack (chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:138215)
    at Object.a.getBackgroundColor (chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:139420)
    at Object.evaluate (chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:109:68263)
    at b.run (chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:76:8610)
    at chrome-extension://lhdoppojpmngadmnindnejefpokejbdd/adapter.bundle.js:76:12663
@marcysutton
Copy link
Contributor

marcysutton commented Nov 26, 2018 •
edited
Loading

Hi @mattjackson1, we need more details to debug this issue. Can you provide a Codepen or working demo that we can use to reproduce this? Otherwise it will be closed.

@WilcoFiers WilcoFiers added fix Bug fixes extension Axe Firefox or Chrome extension issues labels Dec 12, 2018
@stephenmathieson
Copy link
Member

This looks like a duplicate of #1306

stephenmathieson added a commit that referenced this issue Jan 16, 2019
@stephenmathieson
fix: prevent TypeErrors in color-contrast checks
4a8f535 
This patch adds a safeguard to `color.filteredRectStack` which prevents a `TypeError: Cannot read property '0' of undefined` from being thrown.

This is not a perfect solution, but a stop-gap instead. It's still unclear why we're getting `undefined` here. More investigation is needed, but this can happen at a later date.

Closes #1306 and #1259.
@stephenmathieson stephenmathieson mentioned this issue Jan 16, 2019
Merged
4 tasks
stephenmathieson added a commit that referenced this issue Jan 17, 2019
@stephenmathieson
fix: prevent TypeErrors in color-contrast checks (#1320)
a34165c 
This patch adds a safeguard to `color.filteredRectStack` which prevents a `TypeError: Cannot read property '0' of undefined` from being thrown.

This is not a perfect solution, but a stop-gap instead. It's still unclear why we're getting `undefined` here. More investigation is needed, but this can happen at a later date.

Closes #1306 and #1259.
@WilcoFiers WilcoFiers mentioned this issue Jan 30, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension Axe Firefox or Chrome extension issues fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(color-contrast): Prevent crash on large inline elments #1306 dequelabs/axe-core
4 participants
@WilcoFiers @stephenmathieson @marcysutton @mattjackson1