Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axe hangs forever on https://almanac.httparchive.org/en/2021/ecommerce #4360

Closed
1 task done
adamraine opened this issue Mar 5, 2024 · 1 comment · Fixed by #4373
Closed
1 task done

Axe hangs forever on https://almanac.httparchive.org/en/2021/ecommerce #4360

adamraine opened this issue Mar 5, 2024 · 1 comment · Fixed by #4373
Labels
ungroomed Ticket needs a maintainer to prioritize and label

Comments

@adamraine
Copy link

Product

axe-core

Product Version

4.8.2

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

Axe to produce results.

Actual

Axe hangs forever.

How to Reproduce

Run axe-core or the axe extension on this site: https://almanac.httparchive.org/en/2021/ecommerce

Additional context

GoogleChrome/lighthouse#15824
@adamraine adamraine added the ungroomed Ticket needs a maintainer to prioritize and label label Mar 5, 2024
@adamraine adamraine mentioned this issue Mar 5, 2024
Closed
@straker
Copy link
Contributor

straker commented Mar 5, 2024

Thanks for the issue. It just so happens that I just ran into this problem earlier today and opened #4359. For this site's case it's the comment section which produces the problem as the div surrounding the comments has a tabindex=0 and each of the comment blocks contain links and buttons that are the overlapping elements.

This was referenced Mar 13, 2024
Closed
Merged
@WilcoFiers WilcoFiers mentioned this issue Mar 18, 2024
Merged
WilcoFiers added a commit that referenced this issue Mar 18, 2024
@WilcoFiers
fix(target-size): always pass 10x targets (avoid perf bottleneck) (#4376
be327c4 
)

Let targets that are more than 240x240 auto-pass the target-size rule to
avoid performance issues.

QA note: Test that the page provided in
#4360 results in a pass for
the tabpanel in the comment section
(https://almanac.httparchive.org/en/2021/ecommerce)
@attest-team-ci attest-team-ci mentioned this issue Mar 25, 2024
Merged
WilcoFiers added a commit that referenced this issue Mar 25, 2024
@WilcoFiers
chore(release): v4.9.0 (#4380)
d847924 
##
[4.9.0](v4.8.4...v4.9.0)
(2024-03-25)

### Features

- adding the wcag131 tag to the aria-hidden-body rule
([#4349](#4349))
([dd4c3c3](dd4c3c3)),
closes [#4315](#4315)
- **checks:** deprecate aria-busy check
([#4356](#4356))
([be0b555](be0b555)),
closes [#4347](#4347)
[#4340](#4340)
- **color:** add color channel values and luminosity, saturation, clip
functions ([#4366](#4366))
([9e70199](9e70199)),
closes
[/github.com//pull/4365/files#r1517706612](https://github.com/dequelabs//github.com/dequelabs/axe-core/pull/4365/files/issues/r1517706612)
- **i18n:** add Greek Translations
([#3836](#3836))
([3ea9a48](3ea9a48))
- **i18n:** Add Italian translation
([#4344](#4344))
([de1baa9](de1baa9))
- **i18n:** Add Simplified Chinese translation
([#4379](#4379))
([bda7c8d](bda7c8d))
- **i18n:** Add Taiwanese Mandarin translation
([#4299](#4299))
([c5e11de](c5e11de))

### Bug Fixes

- Add LICENSE-3RD-PARTY.txt file
([#4304](#4304))
([daa0fe6](daa0fe6))
- add Object.values polyfill for node <=6
([#4274](#4274))
([5eb867b](5eb867b))
- **aria-required-children:** avoid confusing aria-busy message in
failures ([#4347](#4347))
([591607d](591607d)),
closes [#fail13](https://github.com/dequelabs/axe-core/issues/fail13)
[#4340](#4340)
- avoid reading element-specific node properties of non-element node
types ([#4317](#4317))
([b853b18](b853b18)),
closes [#4316](#4316)
[#4316](#4316)
- **color-contrast:** handle text that is outside `overflow: hidden`
ancestor ([#4357](#4357))
([bdb7300](bdb7300)),
closes [#4253](#4253)
- **color-contrast:** support color blend modes hue, saturation, color,
luminosity ([#4365](#4365))
([7ae4761](7ae4761))
- **d.ts:** RawNodesResult issues
([#4229](#4229))
([d660518](d660518))
- **d.ts:** RunOptions.reporter can be any string
([#4218](#4218))
([e53f5c5](e53f5c5))
- **i18n:** update Italian translations
([#4377](#4377))
([4d65d4b](4d65d4b))
- **listitem:** clarify roleNotValid message
([#4374](#4374))
([0f8a9af](0f8a9af))
- **scrollable-region-focusable:** missing wcag213 tag
([#4201](#4201))
([0080a72](0080a72))
- **target-size:** always pass 10x targets (avoid perf bottleneck)
([#4376](#4376))
([be327c4](be327c4))
- **target-size:** do not crash for nodes with many overlapping widgets
([#4373](#4373))
([1dbea83](1dbea83)),
closes [#4359](#4359)
[#4359](#4359)
[#4360](#4360)
- **utils/get-selector:** ignore 'xmlns' attribute when generating a
selector ([#4303](#4303))
([938b411](938b411))

This PR was opened by a robot 🤖 🎉
@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
@wingn8t wingn8t mentioned this issue Jun 14, 2024
Open
@gurudeep9 gurudeep9 mentioned this issue Jun 23, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this issue Jul 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ungroomed Ticket needs a maintainer to prioritize and label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(target-size): do not crash for nodes with many overlapping widgets dequelabs/axe-core
2 participants
@straker @adamraine