-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): Update CSSOM for nested @import computation #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got most of it. I've asked @stephenmathieson to work with you on refactoring this code. It is too difficult to read, which is going to make it difficult to maintain or update.
Refactoring of CSSOM will be done on the code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for all the new util functions that have been split out into their own files.
@WilcoFiers needs to have final say. Changes look good to me with two caveats:
|
This PR does the below:
@import
.Promise
instead ofaxe.utils.queue
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)