ci: only hold on master commits #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scurker any idea what's up with AppVeyor? |
|
@stephenmathieson I think it hates me. Looks like there's a lot of commits failing, but nothing on status.appveyor.com. Somewhere there is probably a legitimate failure in IE. a4e177b (#1339) and 861371a (#1396) both got merged in after the change this morning and did not run the test suite against IE in CI before the merge. My guess is that something in the CSSOM change (#1339) is breaking/hanging it - but I don't know what. @JKODU would you have any insight? |
WilcoFiers
approved these changes
May 15, 2019
* develop: test: fix test for Safari (#1557) test: fix flakey test (#1573) test: fix tests failing in IE11 (#1570) test: only run IE11 tests in appveyor (#1571) chore: run prettier and format (#1568) test: disable es6 syntax usage within tests directory (#1569) feat(rule): add additional elements to check for incomplete with required children (#1547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)