Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSOM: Tackle nested @import stylesheets #1054

Closed
3 tasks
jeeyyy opened this issue Aug 6, 2018 · 1 comment
Closed
3 tasks

CSSOM: Tackle nested @import stylesheets #1054

jeeyyy opened this issue Aug 6, 2018 · 1 comment
Assignees
Labels
core Issues in the core code (lib/core)

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 6, 2018

As an enhancement to the work done on PR - #958, which aims to fetch and resolve all CSSStyleSheets that are inline, relative and are cross-domain, there is a need to parse CSSStyleRules from each sheet to understand the usage of @import statements to refer to relative or cross-domain sheets, to ascertain if they are to be fetched.

These references can happen at various nested levels and a returned result/ stylesheet of an @import resource could lead to further @imports and so on, so care should be taken to handle infinite recursion.

The issues to tackle are:

@jeeyyy jeeyyy self-assigned this Aug 6, 2018
@jeeyyy jeeyyy added the feat New feature or enhancement label Aug 6, 2018
@jeeyyy jeeyyy mentioned this issue Aug 6, 2018
4 tasks
@jeeyyy jeeyyy added core Issues in the core code (lib/core) and removed feat New feature or enhancement labels Aug 23, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Sep 10, 2018

It is worth tackling this, only after #1113 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core)
Projects
None yet
Development

No branches or pull requests

1 participant