fix: Log instead of error on unknown tag (#1290)

dequelabs · Dec 30, 2018 · f82d773 · f82d773
1 parent 88017be
commit f82d773
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/core/base/audit.js b/lib/core/base/audit.js
@@ -604,9 +604,7 @@ Audit.prototype.normalizeOptions = function(options) {
 			}, only.values);
 
 			if (unmatchedTags.length !== 0) {
-				throw new Error(
-					'Could not find tags `' + unmatchedTags.join('`, `') + '`'
-				);
+				axe.log('Could not find tags `' + unmatchedTags.join('`, `') + '`');
 			}
 		} else {
 			throw new Error(`Unknown runOnly type '${only.type}'`);

diff --git a/test/core/base/audit.js b/test/core/base/audit.js
@@ -1273,8 +1273,8 @@ describe('Audit', function() {
 			});
 		});
 
-		it('throws an error when option.runOnly has an unknown tag', function() {
-			assert.throws(function() {
+		it("doesn't throw an error when option.runOnly has an unknown tag", function() {
+			assert.doesNotThrow(function() {
 				a.normalizeOptions({
 					runOnly: {
 						type: 'tags',