fix(rule): Prevent th-has-data-cells from crashing on empty rows (#1285)

dequelabs · Dec 20, 2018 · 88017be · 88017be
1 parent 5e4b4cc
commit 88017be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/commons/table/get-scope.js b/lib/commons/table/get-scope.js
@@ -44,7 +44,7 @@ table.getScope = function(cell) {
 	var headerCol = tableGrid
 		.map(col => col[pos.x])
 		.reduce((headerCol, cell) => {
-			return headerCol && cell.nodeName.toUpperCase() === 'TH';
+			return headerCol && cell && cell.nodeName.toUpperCase() === 'TH';
 		}, true);
 
 	if (headerCol) {

diff --git a/test/commons/table/get-scope.js b/test/commons/table/get-scope.js
@@ -226,4 +226,15 @@ describe('table.getScope', function() {
 			assert.equal(axe.commons.table.getScope(target), 'row');
 		});
 	});
+
+	it('does not throw on empty rows', function() {
+		fixture.innerHTML =
+			'<table>' +
+			'<tr> </tr>' +
+			'<tr> <th id="target">foo</th> <td>bar</td> </tr>' +
+			'</table>';
+		var target = $id('target');
+		axe._tree = axe.utils.getFlattenedTree(fixture.firstChild);
+		assert.equal(axe.commons.table.getScope(target), 'auto');
+	});
 });