fix(aria-allowed-attr): allow aria-posinset and aria-setsize on row e…

…lements for treegrids (#2952) * allow posinset and setsize on row elements * remove update from lookup table Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
dequelabs · May 25, 2021 · 24e6115 · 24e6115
1 parent 20d89c0
commit 24e6115
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/lib/standards/aria-roles.js b/lib/standards/aria-roles.js
@@ -508,7 +508,9 @@ const ariaRoles = {
       'aria-rowindex',
       'aria-selected',
       'aria-activedescendant',
-      'aria-expanded'
+      'aria-expanded',
+      'aria-posinset',
+      'aria-setsize'
     ],
     superclassRole: ['group', 'widget'],
     nameFromContent: true

diff --git a/test/integration/rules/aria-allowed-attr/passes.html b/test/integration/rules/aria-allowed-attr/passes.html
@@ -1913,9 +1913,31 @@
 <iframe aria-label="value" id="pass82" src="/test/playground.html"></iframe>
 <canvas aria-label="value" id="pass83"></canvas>
 <dl aria-label="value" id="pass84"></dl>
-<input aria-label="value" id="pass85"/>
+<input aria-label="value" id="pass85" />
 <label aria-label="value" id="pass86"></label>
 <meter aria-label="value" id="pass87"></meter>
 <object aria-label="value" id="pass88"></object>
 <svg aria-label="value" id="pass89"></svg>
 <video aria-label="value" id="pass90" controls></video>
+
+<table role="treegrid">
+  <thead>
+    <tr>
+      <th>Col 1</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr
+      id="treegrid"
+      role="row"
+      aria-level="1"
+      aria-posinset="1"
+      aria-setsize="1"
+      aria-expanded="true"
+    >
+      <td role="gridcell">
+        Treegrids are awesome
+      </td>
+    </tr>
+  </tbody>
+</table>
diff --git a/test/integration/rules/aria-allowed-attr/passes.json b/test/integration/rules/aria-allowed-attr/passes.json
@@ -92,6 +92,7 @@
     ["#pass87"],
     ["#pass88"],
     ["#pass89"],
-    ["#pass90"]
+    ["#pass90"],
+    ["#treegrid"]
   ]
 }