Merge pull request #2950 from agreene-coursera/patch-1

FIX: JS error in @axe-core/react caused by stale reference to heading
dequelabs · May 20, 2021 · 20d89c0 · 20d89c0
2 parents 1c53c20 + e2e64e4
commit 20d89c0
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/checks/navigation/heading-order-after.js b/lib/checks/navigation/heading-order-after.js
@@ -113,10 +113,12 @@ function headingOrderAfter(results) {
       return heading.ancestry === path;
     });
     const index = headingOrder.indexOf(heading);
-    headingOrder.splice(index, 1, {
-      level: headingOrder[index].level,
-      result
-    });
+    if (index > -1) {
+      headingOrder.splice(index, 1, {
+        level: headingOrder[index].level,
+        result
+      });
+    }
   });
 
   // remove any iframes that aren't in context (level == -1)