Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git add command to handle paths with spaces #10866

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Laptop765
Copy link

@Laptop765 Laptop765 commented Oct 30, 2024

What are you trying to accomplish?

  • When committing to git the path is not escaped for whitespace so if there is a space in the path name it will fail with an error similar to:
updater | 2024/08/20 06:02:34 ERROR <job_871613656> fatal: pathspec '{{REMAINING PATH AFTER THE SPACE}}' did not match any files

Anything you want to highlight for special attention from reviewers?

  • Nothing in particular

How will you know you've accomplished your goal?

  • Updated the tests to have a space in the path and verified the tests failed
  • Implemented the fix and verified the tests now pass

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
    • I ran rspec spec in the bin/docker-dev-shell common environment
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

This probably doesn't entirely address dependabot#10527 but may be related. See also dependabot#8633.
@Laptop765 Laptop765 requested a review from a team as a code owner October 30, 2024 14:11
@Laptop765 Laptop765 changed the title Main Fix git add command to handle paths with spaces Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants