Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM check fails with whitespace in path #10527

Open
1 task done
cmahnke opened this issue Aug 30, 2024 · 2 comments
Open
1 task done

NPM check fails with whitespace in path #10527

cmahnke opened this issue Aug 30, 2024 · 2 comments
Labels
L: javascript T: bug 🐞 Something isn't working

Comments

@cmahnke
Copy link

cmahnke commented Aug 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

NPM

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

/Source Files/Mocks/package.json

dependabot.yml content

  • package-ecosystem: "npm"
    directory: "/Source Files/Mocks/"
    schedule:
    interval: "weekly"
    groups:
    npm-mocks:
    patterns:
    - '*'

Updated dependency

No response

What you expected to see, versus what you actually saw

This will jus fail, from the logs one can see that /Source (truncated at space) doesn't exist..

The following constructs don't work as well:

directory: "'/Source Files/Mocks/'"
directory: "/Source\ Files/Mocks/"
directory: "/Source\\ Files/Mocks/"

Close only if https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories has been updated with a note on how to use space characters in paths

See also #8633. But this shouldn't be packaging specific in any case...

@cmahnke cmahnke added the T: bug 🐞 Something isn't working label Aug 30, 2024
@cmahnke
Copy link
Author

cmahnke commented Sep 18, 2024

Strangely it now works:

Since the haven't been a release the last 36 hours the issue was likely dueto some dependency - consider adding a test case If it's not under the direct control of GitHub.

@Laptop765
Copy link

Laptop765 commented Oct 30, 2024

I think this line is also failing when there is a space in the path:

run_shell_command("git add #{path}")

The path doesn't seem to be escaped for spaces. I get an error like this:

updater | 2024/08/20 06:02:34 ERROR <job_871613656> fatal: pathspec '{{REMAINING PATH AFTER THE SPACE}}' did not match any files

Edit: mine is a NuGet project.

Laptop765 added a commit to Laptop765/dependabot-core that referenced this issue Oct 30, 2024
This probably doesn't entirely address dependabot#10527 but may be related. See also dependabot#8633.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants