-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace color with new name (same color value) #25405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 25, 2023 21:04
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 25, 2023 21:17
Inactive
Andrew565
approved these changes
Aug 28, 2023
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 28, 2023 20:11
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 28, 2023 20:19
Inactive
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 28, 2023 20:25
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 28, 2023 20:37
Inactive
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 13:21
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 13:22
Inactive
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 13:39
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 13:47
Inactive
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 17:12
In progress
va-vfs-bot
temporarily deployed
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 17:50
Inactive
Mottie
approved these changes
Aug 29, 2023
va-vsp-bot
requested a deployment
to
master/dst1957-replace-deprecated-color/main
August 29, 2023 18:24
In progress
GcioNapoleon
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace color name in scss with new name. Color value remains the same.
Additional Info: found this duplicate color name while creating our figma token. Removing this name as it doesn't follow conventions.
Related issue(s)
Testing done
What areas of the site does it impact?
GI Bill
Acceptance criteria
Quality Assurance & Testing
Error Handling