Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace color with new name (same color value) #25405

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

ataker
Copy link
Contributor

@ataker ataker commented Aug 25, 2023

Summary

Replace color name in scss with new name. Color value remains the same.

Additional Info: found this duplicate color name while creating our figma token. Removing this name as it doesn't follow conventions.

Related issue(s)

Testing done

  • Ensured same color value loaded after replacing name

What areas of the site does it impact?

GI Bill

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@ataker ataker requested a review from a team as a code owner August 25, 2023 20:49
@ataker ataker requested a review from a team August 25, 2023 20:49
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 25, 2023 21:04 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 25, 2023 21:17 Inactive
@ataker ataker requested a review from a team August 25, 2023 21:20
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 28, 2023 20:11 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 28, 2023 20:19 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 28, 2023 20:25 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 28, 2023 20:37 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 29, 2023 13:21 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 29, 2023 13:22 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 29, 2023 13:39 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 29, 2023 13:47 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dst1957-replace-deprecated-color/main August 29, 2023 17:12 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dst1957-replace-deprecated-color/main August 29, 2023 17:50 Inactive
@ataker ataker merged commit 2d9bd20 into main Aug 29, 2023
@ataker ataker deleted the dst1957-replace-deprecated-color branch August 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants