Update Colors based on feedback #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
reviewed
Aug 28, 2023
| $color-link-default: #004795; | ||
| $color-link-visited: #4c2c92; | ||
| $color-warning-message: #fac922; | ||
| $color-gibill-accent: #fff1d2; | ||
| $color-feedback-warning-background: #fac922; |
There was a problem hiding this comment.
When we eventually change-over from Formation to CSS Library, I wonder how we will deal with this token name being changed. It's being used in a few places in Formation (and thus vets-website)
- Formation: https://github.com/search?q=repo%3Adepartment-of-veterans-affairs%2Fveteran-facing-services-tools%20path%3A%2F%5Epackages%5C%2Fformation%5C%2F%2F%20%24color-warning-message&type=code
- vets-webste: https://github.com/search?q=repo%3Adepartment-of-veterans-affairs%2Fvets-website%20%24color-warning-message&type=code
Andrew565
approved these changes
Aug 28, 2023
ataker
added
the
ignore-for-release
|
Next steps in this ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://dst1957-color-feedback--60f9b557105290003b387cd5.chromatic.com
Description
Per feedback:
warning-messagetofeedback-warning-backgroundgibill-accent. After investigation, this is the same color asgold-lightest, updated only usages in vets-website with this PR.orange. After investigation, this is only used in storybook for theUSE WITH CAUTION: PROPOSEDlabel. Moved to storybook css.Partial CSS Library: Generate a Figma token file #1957
Testing done
warning-messageunused in component library, no testing.gibill-accentunused in component library, no testing.orangetested in storybookScreenshots
Acceptance criteria
Definition of done