Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TeamSite doc for devops changes is out of date #43364

Open
jilladams opened this issue Jun 24, 2022 · 5 comments
Open

TeamSite doc for devops changes is out of date #43364

jilladams opened this issue Jun 24, 2022 · 5 comments
Assignees
@laucon @vbellissimo
Labels
documentation-support Incoming documentation support requests triaged by Platform Content pw-footer-feedback for Platform Content

Comments

@jilladams
Copy link
Contributor

jilladams commented Jun 24, 2022 •
edited
Loading

Description

Instructions for devops allow lists reference outdated code: The commit examples linked from https://depo-platform-documentation.scrollhelp.site/developer-docs/teamsite-overview#TeamSiteoverview-Considerationswheneditingandtestingtheallowlist are pointing at a commit hash version of the file. Links from that doc =

  1. https://github.com/department-of-veterans-affairs/devops/blob/c5687fc1b483eaea17a1191eb41440fb560d01d6/terraform/environments/dsva-vagov-prod/main.tf#L277
  2. https://github.com/department-of-veterans-affairs/devops/blob/c5687fc1b483eaea17a1191eb41440fb560d01d6/terraform/environments/dsva-vagov-prod/main.tf#L290

That code has been significantly refactored in master.

TeamSite CORS allowed origins for bucket-prod-va-gov-assets and bucket-preview-va-gov-assets are now part of the vets-api module, so docs should instead point to https://github.com/department-of-veterans-affairs/devops/blob/master/terraform/environments/dsva-vagov-prod/main.tf#L274 in master branch, and instruct users to add new domains to local allowed_origins.

Relevant URLs
@jilladams jilladams added documentation-support Incoming documentation support requests triaged by Platform Content pw-footer-feedback for Platform Content labels Jun 24, 2022
@jilladams jilladams mentioned this issue Jun 24, 2022
Closed
11 tasks
@jilladams jilladams mentioned this issue Jul 12, 2022
Closed
12 tasks
@jilladams jilladams mentioned this issue Jul 20, 2022
Closed
12 tasks
@jilladams jilladams mentioned this issue May 17, 2024
Closed
@laucon
Copy link
Contributor

laucon commented May 31, 2024

I believe that all of this has been resolved on the document, TeamSite overview, and I think that this ticket can be closed.

@laucon laucon self-assigned this May 31, 2024
@jilladams
Copy link
Contributor Author

Hi @laucon - I found one place the Allowlist link is still incorrect in the docs: in this paragraph:

There are an unknown number of TeamSite templates that drive the <head> content on TeamSite pages and there are several pages that receive the above markup that should not show the VA.gov header. The proxy rewrite application uses a [allowlist](https://github.com/department-of-veterans-affairs/vets-website/blob/b770f380270722228563e56629af440c64342157/src/applications/proxy-rewrite/proxy-rewrite-whitelist.json) to drive the activation of the header content. Example allowlist entry:

That URL should be: https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/proxy-rewrite/proxy-rewrite-whitelist.json

Otherwise, looks good! Thank you for getting this handled.

@laucon
Copy link
Contributor

laucon commented Jun 4, 2024 •
edited
Loading

Thanks! I'll create a new Zenhub ticket to fix this and try and get this done ASAP.

@laucon
Copy link
Contributor

laucon commented Jun 4, 2024

@jilladams I edited this. It should get deployed today and then we can close this ticket, I think.

@jilladams
Copy link
Contributor Author

Sounds good!

@jilladams jilladams mentioned this issue Jan 22, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laucon laucon

@vbellissimo vbellissimo

Labels
documentation-support Incoming documentation support requests triaged by Platform Content pw-footer-feedback for Platform Content
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lianilychee @laucon @jilladams @vbellissimo