Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sites to use the Injected Header/Footer: ptsd.va.gov; mirecc.va.gov; mentalhealth.va.gov #20329

Closed
5 tasks
laflannery opened this issue Jan 22, 2025 · 4 comments
Assignees
Labels
Header/footer Owned by Sitewide Public Webites Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2025

Description

The VCL modal on the TeamSite header for these sites is not currently working, so it was requested by Josh Tuscher (VAHELP-8452) that 3 sites be added to use the injected header/footer.

Production url:

Please handle both www and non-www versions of the URL.

Tasks

Public Websites team will need to:

2-2.5hrs

Additional context

DEPO teamsite overview - explains the mechanisms, and has notes on testing, for the implementing team. (And has an incorrect code pointer, ticketed here: department-of-veterans-affairs/va.gov-team#43364)

After PW updates allowlists, the requesting team will need to test on Staging by setting a cookie in browser, per the TeamSite docs. The main issues are styling related, where styles from the site may affect the presentation of the header/footer. Those issues can/should be fixed by updating the CSS of the site / app (rather than by modifying styles for the header / footer globally). This is the bulk of their work, and if no style issues occur, it could potentially be a no-op. Once requesting team confirms that the injected header/footer work and they're ready to publish, PW will manage a separate issue to update code to cookieOnly: false in order to permanently expose the header/footer on the site.

  • Production cookie update ticket:

To test

  • Load the requested URL
  • Open developer tools, Console
  • Type document.cookie = "proxyRewrite=true;", and hit Enter. This creates a cookie that you will then find under Application cookies in dev tools until you clear cookies.
  • Refresh the page, and injected header should load.

Acceptance Criteria

  • On the requested domains, when setting cookie in the console, the global header/footer are injected
  • Let DM know when your changes have deployed to production, so they can notify the requesting team
@laflannery laflannery added Needs refining Issue status sitewide Public Websites Scrum team in the Sitewide crew Header/footer Owned by Sitewide Public Webites labels Jan 22, 2025
@jilladams jilladams added VA.gov frontend CMS team practice area and removed Needs refining Issue status labels Jan 22, 2025
@jilladams
Copy link
Contributor

@chriskim2311 @randimays this popped up after planning. The issue here is that the 3 teamSite subdomains, including the PTSD site, cannot currently open the Veterans Crisis Line modal in the old header. To mitigate that, these sites want to adopt the injected header.

We haven't added new sites to the Injected Header anytime recently, so this is a new process for both of you I know, but the template has extensive details in how to go about it. This is a critical sprint priority so please grab time with me for any questions for whoever picks it up.

@jilladams jilladams changed the title Add new sites to use the Injected Header/Footer Add new sites to use the Injected Header/Footer: ptsd.va.gov; mirecc.va.gov; mentalhealth.va.gov Jan 22, 2025
@randimays randimays self-assigned this Jan 22, 2025
@randimays
Copy link
Contributor

Verified the below domains are working as expected in production:

We can handoff to TeamSites owners to test (testing steps).

@jilladams
Copy link
Contributor

Michelle is running comms with Josh Tuscher in an email chain we are not on, so I'm gonna go ahead and close this. We can reopen as needed.

@randimays
Copy link
Contributor

Closing per Jill's comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Header/footer Owned by Sitewide Public Webites Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants