Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VA Formulary Advisor team adding injected header #9767

Closed
1 of 12 tasks
jilladams opened this issue Jul 12, 2022 · 11 comments
Closed
1 of 12 tasks

Support VA Formulary Advisor team adding injected header #9767

jilladams opened this issue Jul 12, 2022 · 11 comments
Assignees
Labels
Injected header Proxy-rewrite JS app to present header on TeamSites; owned by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented Jul 12, 2022

Description

VA Formulary Advisor plans to adopt the injected header / megamenu.
Currently a file-based site in TeamSite. Site isn't launched so we need to handle both staging prod domains:

  • va.gov/formularyadvisor
  • www.va.gov/formularyadvisor
  • vaww.internet.staging.va.gov/formularyadvisor

Tasks

Our team will need to:

2-2.5hrs.

Additional context

DEPO teamsite overview - explains the mechanisms, and has notes on testing, for the implementing team. (And has an incorrect code pointer, ticketed here: department-of-veterans-affairs/va.gov-team#43364)

After our work, the team will need to test on Staging. Once they confirm that injected header works and they're ready to publish, we'll need to update code to cookieOnly: false . That is separately ticketed under

To test

  • Load https://www.ea.oit.va.gov/
  • Open developer tools, Console
  • Type document.cookie = "proxyRewrite=true;", and hit Enter. This creates a cookie that you will then find under Application cookies in dev tools until you clear cookies.
  • Refresh the page, and injected header should load.

Acceptance Criteria

  • On http://ea.oit.va.gov, when setting cookie in the console the global header is injected
  • Let DM (Jill) know when your changes have deployed to production, so she can notify the VAFW team

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@jilladams jilladams added VA.gov frontend CMS team practice area Needs refining Issue status labels Jul 12, 2022
@github-actions github-actions bot added the Public Websites Scrum team in the Sitewide crew label Jul 12, 2022
@wesrowe wesrowe added the Blocked Issues that are blocked on factors other than blocking issues. label Jul 14, 2022
@wesrowe
Copy link
Contributor

wesrowe commented Jul 14, 2022

Blocked until external team meets with us

@wesrowe wesrowe removed the Needs refining Issue status label Jul 14, 2022
@jilladams jilladams removed the Blocked Issues that are blocked on factors other than blocking issues. label Jul 15, 2022
@jilladams
Copy link
Contributor Author

Team confirmed domain - added to ticket, moving this this to Stretch / Next sprint for S63.

@allisonlu
Copy link
Contributor

allisonlu commented Jul 19, 2022

PR opened on vets-website: department-of-veterans-affairs/vets-website#21711

@allisonlu
Copy link
Contributor

@allisonlu
Copy link
Contributor

Changes merged on both repos. Will confirm that cookie is working later today with the daily deploy

@allisonlu
Copy link
Contributor

@jilladams Do you know if the team has already added these scripts to their HTML? I forgot to confirm during our meeting the other day.

https://depo-platform-documentation.scrollhelp.site/developer-docs/teamsite-overview#TeamSiteoverview-ScriptsandTeamSiteAdministration

@jilladams
Copy link
Contributor Author

Have emailed the team to flag this requirement. Thanks for noting!

@jilladams
Copy link
Contributor Author

@allisonlu the team will add the headers, but no timing shared yet. You're not able to test the cookie til that's done on their end, right?

If that's true, let's close this and I can cut a follow up ticket to test the cookie once they've shipped the scripts.

@allisonlu
Copy link
Contributor

Yup, I won't be able to test until they put in the script. I'll close ticket now

@jilladams
Copy link
Contributor Author

jilladams commented Jul 27, 2022

The VA Formulary Advisor team wants to add the injected header/footer to their TeamSite, which is not yet launched.
We have added the following prod & staging domains to the required allow lists per docs:

The Formulary team added the script lines per docs. So in theory: everything is in place to set the browser cookie to reveal header/footer for testing.

However, when they try to set the cookie, they get a 403 on one of the listed scripts:

GET https://prod-va-gov-assets.s3-us-gov-west-1.amazonaws.com/js/settings.js net::ERR_ABORTED 403 (Forbidden)

Filed a VFS Platform Support ticket to ask for help. We may need to reopen this or file a separate ticket, tbd.

@jilladams
Copy link
Contributor Author

Per Platform support, the script throwing 403 doesn't exist. 🙃 Not reopening ticket, just advising team to remove that script.

2yo ticket for updating docs 🙃 :
department-of-veterans-affairs/va.gov-team#8701

We'll need to keep this in mind for future teams who want the header.

@jilladams jilladams added the Injected header Proxy-rewrite JS app to present header on TeamSites; owned by Public Websites team label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Injected header Proxy-rewrite JS app to present header on TeamSites; owned by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants