-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USABILITY]: Form error handling when users press Continue button should be reviewed #2533
Comments
I tested this on a couple different forms and the behavior is consistent and as described in this ticket. While the page does scroll to focus on the "top" error field, it does not actually go inside of the field to allow immediate editing. Tab has to be pressed first in order to begin editing the field. To me, this is less of an "issue" and more of just a different approach, but I'm not a designer and it may be make way more sense for some users if it actually scopes into the error field instead of just scrolling to it. @luke-gcio As this is now, this is a global form issue and not specific to any one of our forms or any other form. Should we hand this off to another team? I can also look into the code to see how quick of a fix this would be. It may be as simple as going to the place in the code where we scroll to the field and simply telling it to also begin editing the field. |
Digging in a little more, it may be as easy as modifying the |
I think you should discuss this in the accessibility channel. The focus is on the
Either way, I think the |
Maybe I'm confused by the ticket or confused by what you are saying, but are you saying this isn't actually a decided issue, rather a proposed situation to look in to? I was assuming it was already decided to be an issue and that someone had determined that the focus was supposed to be inside of the field. That being said, I don't think there is any CSS change to be made, just simply switching the focus to the input. Regardless, this ticket really sounds like not our problem more and more, especially if it's requiring discussions with designers/accessibility about the global form system. |
I defer to @1Copenut on this, since he initiated this issue. As I understand this: |
@jenstrickland Okay, thank you for explaining. That clarifies a lot! |
We should maintain the current behavior of keeping focus on the Continue button, and having users press
I'm fully on board with working up a proof of concept and researching it with users if there's interest. Pinging @CrystabelReiter && @emilywaggoner for visibility. |
@1Copenut - upon that first |
@jenstrickland Upon pressing Good call that the error handling isn't documented in the form controls. That's something we should fill in. |
Issue
This issue was opened to address this issue across all forms. The content of this issue was copied from #1705 (closed) which was only specifically addressing form 526EZ.
The error handling when users press the
Continue
button was flagged by the VA 508 office during an audit. They said the expected behavior was to focus the first form field in error when users press Continue and one or more fields have errors.I (Trevor Pierce) checked this behavior on other forms, and it seems consistent that we require users to press
TAB
to move from the form to the first input in error on other forms, so it seems our behavior on the 526 disability increase form is consistent. I am putting this issue in as a way to review that behavior and start a larger conversation if necessary.Environment
@1Copenut commented on Mon Sep 24 2018
@Mottie commented on Wed Sep 18 2019
@YanaRoy commented on Tue Oct 1 2019
@1Copenut commented on Tue Oct 1 2019
The text was updated successfully, but these errors were encountered: