Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBE]: 526 V2 error handling when users press Continue button should be reviewed #1705

Closed
aeltarhoni opened this issue Sep 11, 2019 · 4 comments
Assignees
Labels
526 v 1 and 2 accessibility blocked design frontend vsa-claims-appeals VA.gov Claims and appeals (disability compensation)

Comments

@aeltarhoni
Copy link
Contributor

@1Copenut commented on Wed Aug 22 2018

Issue

The error handling when users press the Continue button was flagged by the VA 508 office during an audit. They said the expected behavior was to focus the first form field in error when users press Continue and one or more fields have errors.

I checked this behavior on other forms, and it seems consistent that we require users to press TAB to move from the form to the first input in error on other forms, so it seems our behavior on the 526 disability increase form is consistent. I am putting this issue in as a way to review that behavior and start a larger conversation if necessary.

Environment

  • Windows 7 64 Bit Enterprise Edition SP1
  • Google Chrome
  • JAWS 2018.0

picture4


@1Copenut commented on Mon Sep 24 2018

@djmunoz1 I logged an issue with the US Forms Library repo ( usds/us-forms-system#278 ) about error handling, that seems to line up with this issue. Please advise if you'd like to leave this open, or close it and manage another way.

@aeltarhoni aeltarhoni added accessibility design frontend vsa-claims-appeals VA.gov Claims and appeals (disability compensation) 526 v 1 and 2 labels Sep 11, 2019
@aeltarhoni aeltarhoni added this to the Benefits Sprint 4 milestone Sep 11, 2019
@Mottie
Copy link
Contributor

Mottie commented Sep 18, 2019

Slack response from Trevor Pierce

Hi team.
I reviewed the ticket and this is standard behavior on all of our forms, to require users to press TAB after pressing Continue to get to the first invalid required field. I reached out to the VA 508 team and referenced the new ticket to get a final conclusion.
I’ll set a todo to circle back with them next week and let you know.
No action is required until we have guidance.

@YanaRoy YanaRoy removed this from the Benefits Sprint 4 milestone Sep 25, 2019
@YanaRoy
Copy link
Contributor

YanaRoy commented Oct 1, 2019

@1Copenut following up: is this still blocked?

@1Copenut
Copy link
Contributor

1Copenut commented Oct 1, 2019

@YanaRoy Yes, this is a wider issue that would affect all of our forms. What do you think about closing this item for the 526 specifically and opening a new issue ticket for exploration? It might be better served that way, because any change will be sitewide.

@Mottie
Copy link
Contributor

Mottie commented Oct 17, 2019

Closed. See #2533 which broadens the scope of this issue.

@Mottie Mottie closed this as completed Oct 17, 2019
@YanaRoy YanaRoy changed the title [USABILITY]: 526 V2 error handling when users press Continue button should be reviewed [OBE]: 526 V2 error handling when users press Continue button should be reviewed Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
526 v 1 and 2 accessibility blocked design frontend vsa-claims-appeals VA.gov Claims and appeals (disability compensation)
Projects
None yet
Development

No branches or pull requests

5 participants