-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18544: next build feature flags #18937
Conversation
/** | ||
* The Feature toggle name for outreach checkbox. | ||
*/ | ||
const NEXT_PREVIEW_FEATURE_NAME = 'feature_next_story_preview'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we had implemented a single flag name to control all of Next Preview. That is removed in favor of per-content-type flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but there is an error saving new Feature Toggles, which I reported here.
Despite the error, the Feature Toggle changes did persist, so I continued with QA. All QA steps passed successfully. So this could be approved, if not for the error.
The ExportFeature class was referencing |
…y, and add next entities.
1fdf6b4
to
bd04a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
#18544
There is a sister PR in Next Build to take advantage of this work: department-of-veterans-affairs/next-build#676
This PR should be merged first.
QA steps
All QA as an administrator.
Added feature flags
https://pr18937-l2wpiv91m6dwkyohkppimgnwue7btbyn.ci.cms.va.gov/admin/config/system/feature_toggle should show flags for each content type in the system, rather than just 4
Added Next.js content entities
https://pr18937-l2wpiv91m6dwkyohkppimgnwue7btbyn.ci.cms.va.gov/admin/config/services/next/entity-types should show 7 configured content entities, rather than 2
Feature flags manipulate preview functionality
FEATURE_NEXT_BUILD_CONTENT_EVENT
. Activate it and save.Listing pages only have Preview if they are Next Build enabled.
FEATURE_NEXT_BUILD_CONTENT_EVENT_LISTING
flag, and save.Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?