-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18544: next build feature flags #676
Conversation
@@ -33,8 +33,8 @@ export const processEnv = async (command: string): Promise<void> => { | |||
process.env = { | |||
...process.env, | |||
...{ | |||
...envVars, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ordering is switched to allow developer override of feature flags via their env vars, either locally or on a given environment. In the previous setup, the only way to override the feature flags was via cli options, and that will be difficult for devs to work with and nearly impossible to utilize on say a dev or staging environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not already done, please also link the feature flags docs inside of cms readme's so that no information is lost.
Everything seems to work great. Even when i check all options or even add some of the documented but not present options such as FEATURE_NEXT_BUILD_CONTENT_ALL. Everything worked as expected. |
The testing works for me. I also think the testing instructions would be a great to add to the readme as an example to serve as practice for the user |
… on Prod Next build for pre-launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Do not merge until department-of-veterans-affairs/va.gov-cms#18937 has been merged the work from that PR has filtered down to the main lower Tugboat instance.
This PR, in conjunction with this PR in the CMS, sets up Next Build to use CMS feature flags to determine whether a given content type should be built in Next Build.
Please see https://github.com/department-of-veterans-affairs/next-build/pull/676/files?short_path=a217030#diff-a21703051db1f4ae84b593407423d494143eab7fe3f1f5db420ae1fb3935dad7 for how the feature flags are managed and used in Next Build.
Ticket
department-of-veterans-affairs/va.gov-cms#18544
Developer Task
Tasks
Testing Steps
This is most easily tested with locally-running Next Build against a locally running CMS instance.
Setup
ddev pull va --skip-files
), and then ensure it is running correctly.http://va-gov-cms.ddev.site
rather thanhttps
yarn dev
First tests - enabling content types from the CMS.
FEATURE_NEXT_BUILD_CONTENT_EVENT_LISTING
).FEATURE_NEXT_BUILD_CONTENT_EVENT
).Enabling content types from the environment file.
FEATURE_NEXT_BUILD_CONTENT_VET_CENTER=true
Testing the special all content variable.
FEATURE_NEXT_BUILD_CONTENT_ALL=true
Reviewer
Reviewing a PR
This section lists items that need to be checked or updated when making changes to this repository.
Standard Checks
Tasks