-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimize PR overhead for non-code changes #16279
Conversation
49669b5
to
9365c4d
Compare
9365c4d
to
f4658e6
Compare
f4658e6
to
b3e1ba1
Compare
c384410
to
a12ee32
Compare
|
||
for (const file of files) { | ||
console.log(`Checking PR file: ${file}`) | ||
if (!file.endsWith('.md')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we use the rule that any non-.md
file is a code change, which is probably the safest method for now.
b939612
to
e91ef24
Compare
GitHub Workflows (.github/workflows/*.yml)Have you...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work!
Thanks everyone! |
This reverts commit 176aa38.
This reverts commit 176aa38.
* Revert "Add documentation for Tugboat GHA integration (#16739)" This reverts commit e5bce05. * Revert "Refresh Tugboat Preview ID cache from PR cache scope (#16562)" This reverts commit 48de27e. * Revert "Minimize PR overhead for non-code changes (#16279)" This reverts commit 176aa38. * Update documentation (#17123) * Test PR with documentation change * Update
Description
Resolves #13834. Here's a general overview of the design.
GHA workflows don't happen on documentation-only changes.
paths-ignore
mechanism..github/workflows/set-tugboat-tests-pending.yml
was renamed to.github/workflows/set-tests-statuses.yml
and its role is to set the correct status depending on whether the changes contain code or not. For Doc only PRs, it will set all the status for all required checks to success since the CI and Tugboat deployments are disabled. For PRs containing code changes, the current behaviour of settingva/test/*
status to pending is maintainedContextual Advice
workflow enabled since we may want to add advice based on which doc was updated (e.g. communicate to a Slack channel if a doc is updated, etc). As for theCodeQL
andRepair PR Title
workflows, I'm ambivalent but kept them for now.Tugboat deploy doesn't happen on documentation-only changes
actions/cache
is used to persist the state..github/workflows/tugboat-pr-opened.yml
will be triggered.Testing done
I've tested the changes involving both doc PRs and code PRs in the va.gov-cms-test repo:
I've confirmed that opening, updating and closing the PRs trigger the behaviour described above. Testing of reopening is completed in:
I've also tested the Tugboat Preview ID Cache refresh mechanism using department-of-veterans-affairs/va.gov-cms-test#1462 and confirmed that it ensures the Preview IDs for open PRs are refreshed on a set schedule.
QA steps
Testing this change requires turning off the webhook so it can't be done in this repo. The changes in this PR are mirrored at https://github.com/department-of-veterans-affairs/va.gov-cms-test/tree/13834-mirror. To test these changes, make a PR to that branch similar to the ones linked in the Testing done section.
As any user who can open PRs on this repo
Definition of Done
Documentation has been updated, if applicable.Tests have been added if necessary.If there are field changes, front end output has been thoroughly checked.main
, the Tugboat PR webhooks on this repo can be disabled.Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing