Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize PR overhead for non-code changes. #13834

Closed
2 tasks
Tracked by #15479
ndouglas opened this issue May 25, 2023 · 6 comments · Fixed by #16279
Closed
2 tasks
Tracked by #15479

Minimize PR overhead for non-code changes. #13834

ndouglas opened this issue May 25, 2023 · 6 comments · Fixed by #16279
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area

Comments

@ndouglas
Copy link
Contributor

Description

As someone who hates that we don't have all of the branch protection rules enabled on main,
I should prevent Tugboat deploys and GHA workflow runs on documentation-only PRs
So that people don't look like Walter Donovan in Indiana Jones and the Last Crusade when he drank from the fake Grail while waiting for completely unnecessary test runs to complete.

Acceptance Criteria

  • Tugboat deploy doesn't happen on documentation-only changes
  • GHA workflows don't happen on documentation-only changes.
@ndouglas ndouglas added Needs refining Issue status DevOps CMS team practice area CMS Team CMS Product team that manages both editor exp and devops labels May 25, 2023
@ndouglas
Copy link
Contributor Author

ndouglas commented Sep 12, 2023

This could turn out to be a major PITA/time sink. It's not a huge priority, so it can be abandoned if it turns out to be more complicated than anticipated.

@JunTaoLuo
Copy link
Contributor

@ndouglas
Copy link
Contributor Author

@JunTaoLuo Yeah, big thing is the Tugboat deploy which is currently just using the webhook integration. It should work if we shift it to only dispatch the event conditionally, from a workflow... I would think... but I haven't had much time to look into it 🙁

@BerniXiongA6
Copy link

@JunTaoLuo how many points of this ticket would you say were completed so far? We can carry over ticket if needed (I can calculate the points manually on my planning calculator). cc: @maortiz-27-80

@JunTaoLuo
Copy link
Contributor

I think there's still 5 points left here since I've done about half of the work but the half remaining seems to be trickier.

@BerniXiongA6
Copy link

Thanks @JunTaoLuo ! cc: @maortiz-27-80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants