Update Service Location paragraph type to account for VBA

[xiongjaneg]

Description

Drupal implementation for VBA Service Location paragraph type is built to match the spec #13128. (Note from Dave - the spec has not been updated to reflect the FE design, so it is wildly out of date)

• VBA Content Specs XLS listed in VBA Pilot MVP - Drupal content modeling & spec work #13096

Collaborate with DaveP if questions arise based on the spec during implementation.

Change management notes

We want to add new VBA fields to Service Location, but do not want those fields to be visible in Prod to VAMC editors yet. That requires Change Management. #14758

Acceptance Criteria

• Most recent design is reviewed. [Edited to add updated link]
• Spec is reviewed to accommodate most recent design.
• Design is implemented.
• I expect that these changes may be put in a PR branch pending change management.
• Link to view implementation is shared with Laura for accessibility audit in ticket Accessibility audit of updated Service Location paragraph type #14893
• Note any comments in SPIKE: Proposed path for VAMC Facility Service appointment information migrating into updated Service Location #14837

[jilladams]

@xiongjaneg we need to cut a follow up ticket to put in the backlog for exposing these fields and change management, when the time comes.

[xiongjaneg]

1. Does this include anything about restrictions? In the spec, there's a cardinality restriction on Facility.
2. Is 3 functional or does it need to be increased?
3. Is there work that needs to come before this? Yes. There could be more info added to the spec.

[omahane]

@xiongjaneg I want to confirm that this is the design we're talking about reviewing in in the first AC: https://www.sketch.com/s/891d33ae-152d-471c-ab5d-9aedf89cf6ff/p/FC995695-308A-4493-8461-D9AFE6DC6B25/canvas

[xiongjaneg]

@thejordanwood Can you confirm the Sketch link Christian is referring to is the most recent? Thank you!

[thejordanwood]

@xiongjaneg @omahane This is the Figma file that will have the Service location paragraph type. It's a bit confusing, but CMS designs are in Figma and front end designs are in Sketch.

I just commented on my Service locations ticket and pointed out that, while I've done some UX review of this, I haven't completed the work yet. I'm missing some of the suggestions in Dave's spreadsheet. Specifically the suggestion for better help text to describe what Service Locations are and the addition of the delivery method field.

I'm now realizing that perhaps I should have completed that ticket first, before completing work for Service Regions and other content types that contain the Service Location section.

[xiongjaneg]

@omahane Do you have what you need to continue work on this?

[omahane]

@xiongjaneg @thejordanwood @davidmpickett Can I get some clarity on the title? Is this something that an editor is going to manually create/edit?

Other facility service titles are generated:

Patterns for service titles

Vet Center Service title

• [facility name] - [service name]

VAMC System Health service title

• [service name] at [system name]

VAMC Facility Health service title

• [service name] - [facility name]

[omahane]

The other thing I want to confirm is that, aside from title (which I've asked about above), the only net new field is "Service description." Otherwise, it's mostly help text changes/additions. Is that right, @thejordanwood ?

[davidmpickett]

@xiongjaneg I want to confirm that this is the design we're talking about reviewing in in the first AC: https://www.sketch.com/s/891d33ae-152d-471c-ab5d-9aedf89chttps://www.sketch.com/s/891d33ae-152d-471c-ab5d-9aedf89cf6ff/p/FC995695-308A-4493-8461-D9AFE6DC6B25/canvasf6ff/p/FC995695-308A-4493-8461-D9AFE6DC6B25/canvas

The most recent FE design to review is probably the annotated Service accordion:
https://www.sketch.com/s/891d33ae-152d-471c-ab5d-9aedf89cf6ff/p/578C3207-C5A3-4303-AB18-4AFC27AC54D2/canvas

[davidmpickett]

The other thing I want to confirm is that, aside from title (which I've asked about above), the only net new field is "Service description." Otherwise, it's mostly help text changes/additions. Is that right, @thejordanwood ?

No. There are at least 4 net new fields:

• task-oriented descriptive header
• Service location description
• Service modalities
• appointments ( might need its own nested paragraph type similar to Service location address)

This is what I was referring to when I mentioned the spec was wildly out of date

[davidmpickett]

@xiongjaneg @thejordanwood @davidmpickett Can I get some clarity on the title? Is this something that an editor is going to manually create/edit?

Other facility service titles are generated:

Patterns for service titles

Vet Center Service title

• [facility name] - [service name]

VAMC System Health service title

• [service name] at [system name]

VAMC Facility Health service title

• [service name] - [facility name]

This is a good question, but it's not technically part of Service Location, right? It's something that should be addressed on VBA Facility Service?

[omahane]

You're so right, Dave. I was totally conflating the two, having looked at the Figma file from here: #14704 (comment)

[omahane]

Per Slack conversation with DaveP, we'll be handing the Appointments structure in #14837, rather than doing so here.

[jilladams]

@omahane can you confirm the state of this ticket? Not all ACs are checked, and not sure ifyou need an assist with anything since Jane is gone?

[omahane]

The accessibility review AC is going to have to wait until we've gotten sign-off from @mmiddaugh that our free text fields are the right approach.

[jilladams]

Remaining AC moved to #15649 closing!