remove conditional style.css #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Chiang <[email protected]>
pmclaren19
approved these changes
Nov 20, 2024
10 tasks
davidmpickett
added a commit
that referenced
this pull request
Nov 20, 2024
* Removes registry entry for form-renderer app. (#2345) * Update appName to correct title for Authenticated Experience Design Patterns (#2353) * update appName to correct title * cleanup from merge main * VEBT-729 Removing 22-0993 (#2352) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * Remove 0993-edu-benefits --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * 1217 - Add breadcrumbs (#2356) * CST - Added useLocalStylesAndComponents to the claims-status app (#2360) * add useLocalStylesAndComponents to the claims-status app * update flag placement and registry schema Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Micah Chiang <[email protected]> * remove conditional style.css (#2361) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Ryan Koch <[email protected]> Co-authored-by: Adam Whitlock <[email protected]> Co-authored-by: Liz Wendling <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: Nick Sayre <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]>
davidmpickett
added a commit
that referenced
this pull request
Nov 22, 2024
…BHLPs (#2351) * Update landing_page.drupal.liquid * changing fieldRelatedOffice to fieldConnectWithUs * block -> blockcontent * Rebase 2351 (#2362) * Removes registry entry for form-renderer app. (#2345) * Update appName to correct title for Authenticated Experience Design Patterns (#2353) * update appName to correct title * cleanup from merge main * VEBT-729 Removing 22-0993 (#2352) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * Remove 0993-edu-benefits --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * 1217 - Add breadcrumbs (#2356) * CST - Added useLocalStylesAndComponents to the claims-status app (#2360) * add useLocalStylesAndComponents to the claims-status app * update flag placement and registry schema Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Micah Chiang <[email protected]> * remove conditional style.css (#2361) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Ryan Koch <[email protected]> Co-authored-by: Adam Whitlock <[email protected]> Co-authored-by: Liz Wendling <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: Nick Sayre <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]> * revert header rebase change * spaces fix * more spaces --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Ryan Koch <[email protected]> Co-authored-by: Adam Whitlock <[email protected]> Co-authored-by: Liz Wendling <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: Nick Sayre <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]> Co-authored-by: Eli Selkin <[email protected]>
timcosgrove
pushed a commit
that referenced
this pull request
Nov 26, 2024
…BHLPs (#2351) * Update landing_page.drupal.liquid * changing fieldRelatedOffice to fieldConnectWithUs * block -> blockcontent * Rebase 2351 (#2362) * Removes registry entry for form-renderer app. (#2345) * Update appName to correct title for Authenticated Experience Design Patterns (#2353) * update appName to correct title * cleanup from merge main * VEBT-729 Removing 22-0993 (#2352) * Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * Remove 0993-edu-benefits --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * 1217 - Add breadcrumbs (#2356) * CST - Added useLocalStylesAndComponents to the claims-status app (#2360) * add useLocalStylesAndComponents to the claims-status app * update flag placement and registry schema Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Micah Chiang <[email protected]> * remove conditional style.css (#2361) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Ryan Koch <[email protected]> Co-authored-by: Adam Whitlock <[email protected]> Co-authored-by: Liz Wendling <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: Nick Sayre <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]> * revert header rebase change * spaces fix * more spaces --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Ryan Koch <[email protected]> Co-authored-by: Adam Whitlock <[email protected]> Co-authored-by: Liz Wendling <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: Nick Sayre <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]> Co-authored-by: Eli Selkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the conditional style.css import in the header when
useLocalStyleAndComponentsis present. We're removing it because no apps are opting out of the global stylesheet.