Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CST - Added useLocalStylesAndComponents to the claims-status app #2360

Merged

Conversation

pmclaren19
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

We created a workspace in department-of-veterans-affairs/vets-website#33036 pr but the changes were not being merged into Staging.

Found this platform doc about workspaces and realized we were missing our dependency in the nohoist section so we added that but we still weren't seeing our changes in staging.

After investigating @micahchiang found that the component-library 43.0.2 version that we were setting in the workspace was being overridden buy the root folder and we needed to update content-build for the claim status app to have "useLocalStylesAndComponents": true so the version in our workspace was being used.

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@pmclaren19 pmclaren19 self-assigned this Nov 19, 2024
@pmclaren19 pmclaren19 requested review from a team as code owners November 19, 2024 00:56
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/96817-update-claims-status-workspace-for-component-library November 19, 2024 00:59 Inactive
@micahchiang micahchiang merged commit 3eb2057 into main Nov 19, 2024
24 checks passed
@micahchiang micahchiang deleted the 96817-update-claims-status-workspace-for-component-library branch November 19, 2024 23:38
davidmpickett added a commit that referenced this pull request Nov 20, 2024
* Removes registry entry for form-renderer app. (#2345)

* Update appName to correct title for Authenticated Experience Design Patterns (#2353)

* update appName to correct title

* cleanup from merge main

* VEBT-729 Removing 22-0993 (#2352)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* Remove 0993-edu-benefits

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* 1217 - Add breadcrumbs (#2356)

* CST - Added useLocalStylesAndComponents to the claims-status app (#2360)

* add useLocalStylesAndComponents to the claims-status app

* update flag placement and registry schema

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>

* remove conditional style.css (#2361)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Ryan Koch <[email protected]>
Co-authored-by: Adam Whitlock <[email protected]>
Co-authored-by: Liz Wendling <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Nick Sayre <[email protected]>
Co-authored-by: Peri-Ann McLaren <[email protected]>
davidmpickett added a commit that referenced this pull request Nov 22, 2024
…BHLPs (#2351)

* Update landing_page.drupal.liquid

* changing fieldRelatedOffice to fieldConnectWithUs

* block -> blockcontent

* Rebase 2351 (#2362)

* Removes registry entry for form-renderer app. (#2345)

* Update appName to correct title for Authenticated Experience Design Patterns (#2353)

* update appName to correct title

* cleanup from merge main

* VEBT-729 Removing 22-0993 (#2352)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* Remove 0993-edu-benefits

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* 1217 - Add breadcrumbs (#2356)

* CST - Added useLocalStylesAndComponents to the claims-status app (#2360)

* add useLocalStylesAndComponents to the claims-status app

* update flag placement and registry schema

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>

* remove conditional style.css (#2361)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Ryan Koch <[email protected]>
Co-authored-by: Adam Whitlock <[email protected]>
Co-authored-by: Liz Wendling <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Nick Sayre <[email protected]>
Co-authored-by: Peri-Ann McLaren <[email protected]>

* revert header rebase change

* spaces fix

* more spaces

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Ryan Koch <[email protected]>
Co-authored-by: Adam Whitlock <[email protected]>
Co-authored-by: Liz Wendling <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Nick Sayre <[email protected]>
Co-authored-by: Peri-Ann McLaren <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
timcosgrove pushed a commit that referenced this pull request Nov 26, 2024
…BHLPs (#2351)

* Update landing_page.drupal.liquid

* changing fieldRelatedOffice to fieldConnectWithUs

* block -> blockcontent

* Rebase 2351 (#2362)

* Removes registry entry for form-renderer app. (#2345)

* Update appName to correct title for Authenticated Experience Design Patterns (#2353)

* update appName to correct title

* cleanup from merge main

* VEBT-729 Removing 22-0993 (#2352)

* Update SCO registry.json route

* vagovprod to true for sco page

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

* VEBT-423 Update SCO registry.json route to match prod (#2245)

* Update SCO registry.json route

* Update registry.json for sco url

* Making separate PR

* Fix to breadcrumb padding on certain drupal pages. (#2241)

* Fix to breadcrumb padding on certain drupal pages.

* Adding row back

* Removing another un-needed class

* Adding padding to containing div

* Turn on production flag for rollout (#2246)

* update web-components (#2249)

* update web-components

Signed-off-by: Micah Chiang <[email protected]>

* bump version

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>

* Medallia - Add feedback button to checklist page layout (#2247)

* added feedback button to checklist drupal template

* moved element to under back-to-top element

* VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

* creates va-healthcare-services.json
* remove spaces from JSONs
* process the processed HTML to text
* simplify

* bump web components (#2250)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* Remove 0993-edu-benefits

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>

* 1217 - Add breadcrumbs (#2356)

* CST - Added useLocalStylesAndComponents to the claims-status app (#2360)

* add useLocalStylesAndComponents to the claims-status app

* update flag placement and registry schema

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>

* remove conditional style.css (#2361)

Signed-off-by: Micah Chiang <[email protected]>

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Ryan Koch <[email protected]>
Co-authored-by: Adam Whitlock <[email protected]>
Co-authored-by: Liz Wendling <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Nick Sayre <[email protected]>
Co-authored-by: Peri-Ann McLaren <[email protected]>

* revert header rebase change

* spaces fix

* more spaces

---------

Signed-off-by: Micah Chiang <[email protected]>
Co-authored-by: Ryan Koch <[email protected]>
Co-authored-by: Adam Whitlock <[email protected]>
Co-authored-by: Liz Wendling <[email protected]>
Co-authored-by: Andrew Steele <[email protected]>
Co-authored-by: Kevin Duensing <[email protected]>
Co-authored-by: Micah Chiang <[email protected]>
Co-authored-by: Aubrey Arcangel <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Co-authored-by: Nick Sayre <[email protected]>
Co-authored-by: Peri-Ann McLaren <[email protected]>
Co-authored-by: Eli Selkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants