Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic-release and update build #490

Closed
wants to merge 2 commits into from
Closed

Add semantic-release and update build #490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10eb4b7
chore: add semantic-release and update build
andresriveratoro Jul 20, 2022
a1a9230
chore: add semantic-release to CI
andresriveratoro Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@
"trim": "^0.0.3",
"prism": "^1.27.0"
},
"scripts": {
"semantic-release": "yarn workspaces run semantic-release -e semantic-release-monorepo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we run yarn semantic-release, what will happen?

},
"dependencies": {
"webpack": "5"
},
"devDependencies": {
"semantic-release": "^19.0.3",
"semantic-release-monorepo": "^7.0.5"
}
}
2 changes: 1 addition & 1 deletion packages/css-library/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"platforms": {
"css": {
"transformGroup": "css",
"buildPath": "src/tokens/",
"buildPath": "dist/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would publish all of our CSS in this directory as well, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our build command "sass --load-path=../../node_modules/@uswds/uswds/packages/ src/stylesheets:dist/" takes care of this work. This buildPath change only affects tokens outputted as CSS variables.

"files": [
{
"destination": "_variables.css",
Expand Down
5 changes: 3 additions & 2 deletions packages/css-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"name": "@department-of-veterans-affairs/css-library",
"private": true,
"description": "VA.gov CSS library",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to include Design System in there.

"version": "1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we publish it as 0.0.1 or something instead of a 1.0?

"packageManager": "[email protected]",
"files": [
"dist/*.css"
"dist/*"
],
"scripts": {
"build:tokens": "style-dictionary build",
Expand Down
Loading