Add semantic-release and update build #490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresriveratoro
added
the
ignore-for-release
k80bowman
reviewed
Jul 20, 2022
| @@ -3,7 +3,7 @@ | |||
| "platforms": { | |||
| "css": { | |||
| "transformGroup": "css", | |||
| "buildPath": "src/tokens/", | |||
| "buildPath": "dist/", | |||
There was a problem hiding this comment.
This would publish all of our CSS in this directory as well, correct?
There was a problem hiding this comment.
Our build command "sass --load-path=../../node_modules/@uswds/uswds/packages/ src/stylesheets:dist/" takes care of this work. This buildPath change only affects tokens outputted as CSS variables.
bkjohnson
reviewed
Jul 20, 2022
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/css-library", | |||
| "private": true, | |||
| "description": "VA.gov CSS library", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Can we publish it as 0.0.1 or something instead of a 1.0?
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/css-library", | |||
| "private": true, | |||
| "description": "VA.gov CSS library", | |||
There was a problem hiding this comment.
We may also want to include Design System in there.
package.json
Outdated
| @@ -18,7 +18,14 @@ | |||
| "trim": "^0.0.3", | |||
| "prism": "^1.27.0" | |||
| }, | |||
| "scripts": { | |||
| "semantic-release": "yarn workspaces run semantic-release -e semantic-release-monorepo" | |||
There was a problem hiding this comment.
If we run yarn semantic-release, what will happen?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://1021-token-library--60f9b557105290003b387cd5.chromatic.com
Description
Closes department-of-veterans-affairs/vets-design-system-documentation#1021
Acceptance criteria
Definition of done