Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancel method to DispositionTask #9823

Merged
merged 14 commits into from
Mar 8, 2019
Merged

Add cancel method to DispositionTask #9823

merged 14 commits into from
Mar 8, 2019

Commits on Mar 7, 2019

  1. starting failing tests for DispositionTask.cancel!

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    13589a8 View commit details
    Browse the repository at this point in the history

  2. cancel task when hearing disposition is canceled

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    5168fa2 View commit details
    Browse the repository at this point in the history

  3. cancel the parent HearingTask

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    13506a7 View commit details
    Browse the repository at this point in the history

  4. update legacy appeal location on cancel 

    Need to confirm that we should be calling withdraw_hearing here, as we
do for ScheduleHearingTasks.
    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    d2eaf5e View commit details
    Browse the repository at this point in the history

  5. create IHP task(s) on cancel if ama appeal

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    18a27d9 View commit details
    Browse the repository at this point in the history

  6. add frozen string literal comment to new factory

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    35503c6 View commit details
    Browse the repository at this point in the history

  7. don't withdraw the hearing

    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    cdf6a2b View commit details
    Browse the repository at this point in the history

  8. simplify HearingTask cancellation logic 

    HearingTask will now be cancelled if no children are active and one
child is a canceled DispositionTask
    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    f170758 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/master' into queue/tomas/9539-ca… 

    …ncel-disposition-task-flow
    Tomas Apodaca committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6b98e25 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into queue/tomas/9539-cancel-disposition-task-flow

    va-bot authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    7583b00 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into queue/tomas/9539-cancel-disposition-task-flow

    va-bot authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    5bc9aef View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into queue/tomas/9539-cancel-disposition-task-flow

    @tomas-nava
    tomas-nava authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    8afcf11 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into queue/tomas/9539-cancel-disposition-task-flow

    va-bot authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    d061d97 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. refactor status logic into after_update hooks

    Tomas Apodaca committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    fd7d673 View commit details
    Browse the repository at this point in the history