-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel method to DispositionTask #9823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to confirm that we should be calling withdraw_hearing here, as we do for ScheduleHearingTasks.
tomas-nava
commented
Mar 7, 2019
tomas-nava
commented
Mar 7, 2019
HearingTask will now be cancelled if no children are active and one child is a canceled DispositionTask
…ncel-disposition-task-flow
sharonwarner
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
tomas-nava
added
the
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
label
Mar 7, 2019
ghost
assigned va-bot
Mar 7, 2019
ghost
removed
the
In-Progress
label
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ready-to-Merge
This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9539
Description
Adds a
cancel!
method to theDispositionTask
that makes required changes on parentHearingTask
and associated legacy/ama appeal.